[ENH] improved simple assertion error message in evalutation/functions.py#1600
Merged
fkiraly merged 7 commits intoopenml:mainfrom Feb 15, 2026
Merged
[ENH] improved simple assertion error message in evalutation/functions.py#1600fkiraly merged 7 commits intoopenml:mainfrom
evalutation/functions.py#1600fkiraly merged 7 commits intoopenml:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
+ Coverage 44.44% 52.07% +7.63%
==========================================
Files 36 36
Lines 4351 4351
==========================================
+ Hits 1934 2266 +332
+ Misses 2417 2085 -332 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
changed the title
evalutation/functions.py
geetu040
suggested changes
Jan 12, 2026
openml/evaluations/functions.py
Outdated
Comment on lines
234
to
236
| assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), type( | ||
| evals_dict["oml:evaluations"], | ||
| evals_dict["oml:evaluations"]["oml:evaluation"], | ||
| ) |
Collaborator
There was a problem hiding this comment.
This can be descriptive.
Contributor
Author
There was a problem hiding this comment.
Not sure I got what you mean, should I change something or not?
Collaborator
There was a problem hiding this comment.
assertion message can be improved like this:
"Expected 'oml:evaluations.oml:evaluation' to be a list, but got ..."
Contributor
Author
It's not. It's a slight mistake I found while reading the code for evaluation functions |
geetu040
approved these changes
Jan 13, 2026
Collaborator
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
LGTM!
CC: @fkiraly @SimonBlanke for review/merge.
SimonBlanke
approved these changes
Jan 20, 2026
EmanAbdelhaleem
force-pushed
the
slight_fix
branch
from
413375d to
07f4461
Compare
geetu040
suggested changes
Feb 5, 2026
openml/evaluations/functions.py
Outdated
Comment on lines
234
to
237
| assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), ( | ||
| "Expected 'oml:evaluation' to be a list, but got" | ||
| ) | ||
| f"{type(evals_dict['oml:evaluations']['oml:evaluation']).__name__}. " |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), ( | |
| "Expected 'oml:evaluation' to be a list, but got" | |
| ) | |
| f"{type(evals_dict['oml:evaluations']['oml:evaluation']).__name__}. " | |
| assert isinstance(evals_dict["oml:evaluations"]["oml:evaluation"], list), ( | |
| "Expected 'oml:evaluation' to be a list, but got" | |
| f"{type(evals_dict['oml:evaluations']['oml:evaluation']).__name__}. " | |
| ) |
EmanAbdelhaleem
force-pushed
the
slight_fix
branch
from
33ca852 to
a034a5a
Compare
geetu040
approved these changes
Feb 6, 2026
fkiraly
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
fixed a simple assertion error message in
evalutation/functions.py